Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_parameter_from_event to follow the function description #1922

Merged
merged 1 commit into from
May 3, 2022
Merged

Update get_parameter_from_event to follow the function description #1922

merged 1 commit into from
May 3, 2022

Conversation

Barry-Xu-2018
Copy link
Collaborator

Address #1921

@Barry-Xu-2018
Update get_parameter_from_event to follow the function description
87c0387 
Signed-off-by: Barry Xu <barry.xu@sony.com>
fujitatomoya
fujitatomoya approved these changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Treborsky
Treborsky approved these changes Apr 26, 2022
View reviewed changes
Copy link

@Treborsky Treborsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

jacobperron
jacobperron approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobperron jacobperron merged commit b8b64b4 into ros2:master May 3, 2022
@jacobperron jacobperron mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@alsora alsora alsora approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Treborsky Treborsky Treborsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Barry-Xu-2018 @fujitatomoya @jacobperron @alsora @Treborsky