Fix subscription.is_serialized() for callbacks with message info

[ivanpauno]

I think this was broken when support for type adaption was added.
Currently if you create a serialized subscription with a callback taking both the message and the message info, the executor throws an exception the first time a message is dispatched.

This fixes the issue.

[clalancette]

Yikes, we probably didn't notice because there wasn't a test.

Can you add tests that exercise this?

[ivanpauno]

Can you add tests that exercise this?

I have added some tests for AnySubscriptionCallback covering this case.
See 199d36b.

I would also like to have a test with a publisher and a subscription for each of the callbacks, and make sure the message arrives.
We don't currently have tests like that in rclcpp, I think that we added all of them in test_rclcpp (system_tests repo), so I could add one doing something like that there.

[clalancette]

I would also like to have a test with a publisher and a subscription for each of the callbacks, and make sure the message arrives.
We don't currently have tests like that in rclcpp, I think that we added all of them in test_rclcpp (system_tests repo), so I could add one doing something like that there.

Yeah, we typically have tests like that in test_rclcpp or test_communication. I think it would be fine if you wanted to add some tests there, though I would be careful about adding all combinations; I don't want to explode our CI times.

[clalancette]

Looks good to me with green CI (I'd be sure to run CI with --packages-above rclcpp)

[ivanpauno]

• Linux
• Linux-aarch64
• Windows

[ivanpauno]

windows issues are unrelated (happening in nightlies as well https://ci.ros2.org/view/nightly/job/nightly_win_rel/2329/msbuild/new/).
Going in!