-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support regex match for parameter client #1992
support regex match for parameter client #1992
Conversation
@iuhilnehc-ynos there are conflicts on this PR, could you address it? and do we have issue or reference against this PR? |
60e2c8c
to
0f42d78
Compare
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
No, I didn't create an issue. Thanks for mentioning it. I am going to create it. |
@iuhilnehc-ynos yeah it would be nice for reviewers to describe what exactly we are addressing to. it does not have to be issue, i think we can add description on this PR too. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, can you run CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above comment
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@iuhilnehc-ynos I think this is set to go, so feel free to merge when you are ready. |
to implement #1997
Signed-off-by: Chen Lihui lihui.chen@sony.com