Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak #1994

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix memory leak #1994

merged 1 commit into from
Aug 18, 2022

Conversation

iuhilnehc-ynos
Copy link
Collaborator

to fix #1993

Signed-off-by: Chen Lihui lihui.chen@sony.com

fix memory leak
fe045f7 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora
alsora approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@alsora alsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks for fixing the leak!

clalancette
clalancette approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. Looks good with green CI.

@iuhilnehc-ynos
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@iuhilnehc-ynos
Copy link
Collaborator Author

Update build parameter from --packages-select rclcpp to --packages-up-to rclcpp.
CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 3d69031 into ros2:rolling Aug 18, 2022
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023
fix memory leak (ros2#1994)
1111770 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023
fix memory leak (ros2#1994)
e3ac684 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request May 3, 2023
fix memory leak (ros2#1994)
aadc3e1 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request May 3, 2023
fix memory leak (ros2#1994)
5a96a47 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@alsora alsora alsora approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory leak in rclcpp::parameter_map_from_yaml_file
4 participants
@iuhilnehc-ynos @clalancette @alsora @fujitatomoya