-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force compiler warning if callback handles not captured #2000
Conversation
531ca58
to
992eab1
Compare
Uncrustify seems to be complaining about something, but I can't figure out what or how to fix it. Guidance would be appreciated. |
PR looks good to me. The uncrustify output is the following
The problem is that you have trailing whitespaces at the end of the comments. |
clarify documentation to show that not capturing returned handles will result in callbacks immediately being unregistered Signed-off-by: Jason Beach <jason.m.beach@gmail.com>
what's the typical workflow you follow for using uncrustify? I normally use clangd and for that there's a .clangd / .clang-format / .clang-tidy file in the top level of the repo. For uncrustify, it looks like it takes a .cfg file to define the formatting, but I couldn't find one in the repo. |
Ros projects like this do not invoke uncrustify directly, but rather they use the "ament_uncrustify" wrapper. |
all issues fixed. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This was approved and has green CI, so I'm going ahead and merging it. |
force a compiler warning if callback handles are not captured.
clarify documentation to show that not capturing returned handles
will result in callbacks immediately being unregistered
see issue #1998
Signed-off-by: Jason Beach