Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclcpp shutdown abnormally when rclcpp initiated with rclcpp::SignalHandlerOptions::None #2020

Closed
uupks opened this issue Oct 4, 2022 · 2 comments

Comments

@uupks
Copy link
Contributor

uupks commented Oct 4, 2022

Bug report

Required Info:

  • Operating System:
    • Android NDK r23c
  • Installation type:
    • source
  • Version or commit hash:
    • humble
  • DDS implementation:
    • cyclonedds
  • Client library (if applicable):
    • rclcpp

Steps to reproduce issue

int main(int argc, char *argv[])
{
    rclcpp::init(argc, argv, rclcpp::InitOptions(), rclcpp::SignalHandlerOptions::None);
    rclcpp::shutdown();
    return 0;
}

Expected behavior

exit normally

Actual behavior

[DEBUG] [1661888770.858106131] [rcl]: Shutting down ROS client library, for context at address: 0xb4000071f661c7f0
[DEBUG] [1661888770.858455141] [rclcpp]: SignalHandler::uninstall(): notifying deferred signal handler
terminating with uncaught exception of type std::__ndk1::system_error: thread::join failed: Invalid argument
Aborted

Additional information

rclcpp

If rclcpp is initiated with rclcpp::SignalHandlerOptions::None, signal_handler_thread will not be created.


Feature request

Feature description

#2019

if(signal_handler_thread_.joinable()) {
  signal_handler_thread_.join();
}

Implementation considerations

@uupks uupks changed the title rclcpp shutdown abnormally when rclcpp inited with rclcpp::SignalHandlerOptions::None rclcpp shutdown abnormally when rclcpp initiated with rclcpp::SignalHandlerOptions::None Oct 4, 2022
@uupks uupks closed this as completed Oct 14, 2022
@dawierha
Copy link

How did you solve the problem?

@mjcarroll
Copy link
Member

This was fixed via: #2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants