-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default constructor to NodeInterfaces #2094
Add default constructor to NodeInterfaces #2094
Conversation
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@@ -44,6 +44,10 @@ struct NodeInterfacesStorage | |||
: interfaces_(init_tuple<decltype(node), InterfaceTs ...>(node)) | |||
{} | |||
|
|||
NodeInterfacesStorage() // NOLINT(runtime/explicit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this NOLINT directive is not necesary. cpplint only enforces the usage of explicit
for constructors with a single argument.
I tested it locally and the linters were happy with the NOLINT comment removed!
NodeInterfacesStorage() // NOLINT(runtime/explicit) | |
NodeInterfacesStorage() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e654446
Signed-off-by: Shane Loretz <sloretz@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with @methylDragon comment resolved.
Since changes since full CI just remove a comment, I think only linter tests are needed. I'll merge if the Rpr job comes back green. |
This adds a default constructor. This allows a class to have an
interfaces
member that get's populated by an argument to it's constructor.