Allow publishing borrowed messages with intra-process enabled #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
There was a problem hiding this comment.
@MiguelCompany the fix looks good to me, but i think we need to address rpr job failures cz of this change.
alsora
approved these changes
Feb 16, 2023
|
@MiguelCompany after Rpr failures are addressed, i will start the CI. |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
@fujitatomoya I updated the tests accordingly to the changes. |
fujitatomoya
approved these changes
Feb 17, 2023
|
CI:
|
|
@fujitatomoya Do you think this can be merged? I also think it can be backported into Humble |
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 24, 2023
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 3062dec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids a runtime_error exception when trying to publish a
LoanedMessageon a publisher that has intra-process enabled.The changes make
can_loan_messages()return false in that case, which in turn makesborrow_loaned_message()allocate a standard message.