Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements on the executor #2125

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

mjcarroll
Copy link
Member

Add documentation to a few undocumented methods.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
rclcpp/include/rclcpp/executor.hpp Outdated Show resolved Hide resolved
rclcpp/include/rclcpp/executor.hpp Outdated Show resolved Hide resolved
rclcpp/include/rclcpp/executor.hpp Outdated Show resolved Hide resolved
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@mjcarroll mjcarroll merged commit 18dd05f into rolling Mar 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the mjcarroll/executor_doc branch March 13, 2023 22:23
Barry-Xu-2018 pushed a commit to Barry-Xu-2018/rclcpp that referenced this pull request Jan 12, 2024
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants