Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Switch lifecycle to use the RCLCPP macros #2234

Merged
merged 1 commit into from Jul 24, 2023
Merged

Backport: Switch lifecycle to use the RCLCPP macros #2234

merged 1 commit into from Jul 24, 2023

Conversation

tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented Jul 7, 2023 •
edited

Backport of #2233. Tested on Humble, works as expected.

@clalancette
Copy link
Contributor

@tonynajjar Can you add a Signed-off-by line to the comment please?

@tonynajjar tonynajjar force-pushed the lifecycle-use-rclcpp-macros branch from fdbb852 to 766c69a Compare July 7, 2023 12:41
Switch lifecycle to use the RCLCPP macros Signed-off-by: Tony Najjar …
3210658 
…<tony.najjar.1997@gmail.com>

Signed-off-by: Tony Najjar <tony.najjar@logivations.com>
@tonynajjar tonynajjar force-pushed the lifecycle-use-rclcpp-macros branch from 766c69a to 3210658 Compare July 7, 2023 12:45
@tonynajjar
Copy link
Contributor Author

CI fails to build rclcpp. I had the same error locally, I had to clone rcl and rebuild rclcpp from scratch.

@clalancette
Copy link
Contributor

Yeah, we need to do a release of rcl into Humble to fix that. @audrow what are your plans for a full Humble patch release?

@clalancette
Copy link
Contributor

Regardless, that doesn't block this PR; we can build everything from source and get confidence that way. That said, I'm not going to do any of that until #2233 is merged into Rolling.

@tonynajjar
Copy link
Contributor Author

Regardless, that doesn't block this PR; we can build everything from source and get confidence that way. That said, I'm not going to do any of that until #2233 is merged into Rolling.

Makes sense. I quickly checked that for Iron there are no conflicts, so it should be a smooth backport with mergify

@clalancette clalancette self-assigned this Jul 20, 2023
@clalancette
Copy link
Contributor

clalancette commented Jul 20, 2023 •
edited

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit ec4d00e into ros2:humble Jul 24, 2023
2 of 3 checks passed
@fujitatomoya fujitatomoya mentioned this pull request Jul 24, 2023
Merged
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/new-packages-and-patch-release-for-humble-hawksbill-2023-07-24/32523/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tonynajjar @clalancette @ros-discourse @fujitatomoya