Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpplint on xenial #556

Merged
merged 3 commits into from
Sep 20, 2018
Merged

Fix cpplint on xenial #556

merged 3 commits into from
Sep 20, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Sep 13, 2018

It looks like there is a false positive cpplint violation on xenial (ros2/build_farmer#147).

I'm guessing it either had an issue with the same variable name being used in the shared pointer deleter, or it didn't recognize execution stops at throw_from_rcl_error above.

First attempt: change variable name in lambda.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

connects to ros2/build_farmer#147

@sloretz sloretz added the in progress Actively being worked on (Kanban column) label Sep 13, 2018
@sloretz sloretz self-assigned this Sep 13, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Sep 13, 2018

CI xenial just rclcpp Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Sep 13, 2018 •
edited
Loading

Second attempt, set handler to null Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Sep 13, 2018

Xenial passed, CI on all the other platforms

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Sep 13, 2018
@sloretz sloretz requested a review from dhood September 13, 2018 21:54
@sloretz sloretz mentioned this pull request Sep 13, 2018
Closed
@dhood
Copy link
Member

dhood commented Sep 19, 2018

sorry for the delay on this @sloretz I missed the notification. In 7baeebd I made the same change further down and will re-run CI. Looks good.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • xenial Build Status

@sloretz sloretz merged commit e8d3fdd into master Sep 20, 2018
@sloretz sloretz deleted the false_positive_cpplint branch September 20, 2018 16:19
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhood dhood dhood approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @dhood