Refactor server goal handle's try_canceling() function #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes use of rcl_action_goal_handle_is_cancelable() for one less rcl_action call.
jacobperron
added
in progress
sloretz
approved these changes
Jan 8, 2019
|
CI (packages up to test_rclcpp)
|
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
Makes use of rcl_action_goal_handle_is_cancelable() for one less rcl_action call.
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Remove deprecated CLI rules Resolves ros2#500 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove tests for deprecated CLI arguments Signed-off-by: Jacob Perron <jacob@openrobotics.org>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…ge (ros2#603) * Mutex-protected writes and topic creation/removal in sqlite_storage Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of rcl_action_goal_handle_is_cancelable() for one less rcl_action call.
Follow up from #593.
This PR does not require immediate attention.