Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors from uncrustify v0.68 #613

Merged
merged 1 commit into from Dec 21, 2018
Merged

Fix errors from uncrustify v0.68 #613

merged 1 commit into from Dec 21, 2018

Conversation

jacobperron
Copy link
Member

Connects to ros2/rosidl#340
Connects to ament/uncrustify_vendor#3

@jacobperron jacobperron added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 19, 2018
@jacobperron jacobperron merged commit 22abd62 into master Dec 21, 2018
@jacobperron jacobperron deleted the uncrustify_v68 branch December 21, 2018 18:06
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Dec 21, 2018
nuclearsandwich pushed a commit that referenced this pull request Jan 8, 2019
nuclearsandwich added a commit that referenced this pull request Jan 9, 2019
cho3 pushed a commit to cho3/rclcpp that referenced this pull request Jun 3, 2019
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
Debugging ros2#611 these timeouts were so long that the overall test timeout was being triggered before these internal timeouts were triggered.

1000 retries at 100ms -> 10 seconds each. I cut it down to 1 second for each to establish the connection.

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* Fix relative metadata path writing in compression by deduplicating business logic

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants