You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a method to Publisher and Subscription classes, which allows querying if intraprocess communication is enabled or not.
boolis_intra_process_comm_enabled() const;
Reasoning
In #674 an extra argument has been added to create_publisher and create_subscription methods in Node class, which allows choosing if intraprocess communication is enabled or not with more granularity. The argument default value is NodeDefault which enables it or not depending on the node settings. That was the previous behavior.
Now, It's no way of checking if a publisher or subscriber has the intraprocess comm activated.
Also, it doesn't exist any test which sets the intraprocess comm with pub/sub granularity. This will allow to easily add a test.
Implementation considerations
Both publisher and subscriber has a bool storing the intraprocess subscription state, so we have to just return it.
I think it's also a good idea to add a test with intraprocess comm being set with pub/sub granularity.
The text was updated successfully, but these errors were encountered:
ivanpauno
changed the title
Add API for queering if intraprocess comm is enabled in pub/subs
Add API for querying if intraprocess comm is enabled in pub/subs
Apr 9, 2019
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this issue
Jul 9, 2022
…os2#689)
* Initial PlayerClock integration - functionality unchanged
* Create PlayerClock, a pure virtual interface with `now()`, and `sleep_until()` for Player to use to control timing of message playback
* TimeControllerClock implementation of PlayerClock
* Removes time handling from `Player` in favor of using this new class
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Feature request
Feature description
Add a method to
Publisher
andSubscription
classes, which allows querying if intraprocess communication is enabled or not.Reasoning
In #674 an extra argument has been added to
create_publisher
andcreate_subscription
methods inNode
class, which allows choosing if intraprocess communication is enabled or not with more granularity. The argument default value isNodeDefault
which enables it or not depending on the node settings. That was the previous behavior.Now, It's no way of checking if a publisher or subscriber has the intraprocess comm activated.
Also, it doesn't exist any test which sets the intraprocess comm with pub/sub granularity. This will allow to easily add a test.
Implementation considerations
Both publisher and subscriber has a bool storing the intraprocess subscription state, so we have to just return it.
I think it's also a good idea to add a test with intraprocess comm being set with pub/sub granularity.
The text was updated successfully, but these errors were encountered: