Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for querying if intraprocess comm is enabled in pub/subs #689

Open
ivanpauno opened this issue Apr 8, 2019 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@ivanpauno
Copy link
Member

ivanpauno commented Apr 8, 2019

Feature request

Feature description

Add a method to Publisher and Subscription classes, which allows querying if intraprocess communication is enabled or not.

bool
is_intra_process_comm_enabled() const;

Reasoning

In #674 an extra argument has been added to create_publisher and create_subscription methods in Node class, which allows choosing if intraprocess communication is enabled or not with more granularity. The argument default value is NodeDefault which enables it or not depending on the node settings. That was the previous behavior.
Now, It's no way of checking if a publisher or subscriber has the intraprocess comm activated.
Also, it doesn't exist any test which sets the intraprocess comm with pub/sub granularity. This will allow to easily add a test.

Implementation considerations

Both publisher and subscriber has a bool storing the intraprocess subscription state, so we have to just return it.
I think it's also a good idea to add a test with intraprocess comm being set with pub/sub granularity.

@ivanpauno ivanpauno added the enhancement New feature or request label Apr 8, 2019
@wjwwood
Copy link
Member

wjwwood commented Apr 8, 2019

Makes sense to me.

@ivanpauno ivanpauno assigned ivanpauno and unassigned ivanpauno Apr 9, 2019
@ivanpauno ivanpauno changed the title Add API for queering if intraprocess comm is enabled in pub/subs Add API for querying if intraprocess comm is enabled in pub/subs Apr 9, 2019
nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this issue Aug 5, 2022
…os2#689)

* Initial PlayerClock integration - functionality unchanged

* Create PlayerClock, a pure virtual interface with `now()`, and `sleep_until()` for Player to use to control timing of message playback
* TimeControllerClock implementation of PlayerClock
* Removes time handling from `Player` in favor of using this new class

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@fujitatomoya fujitatomoya self-assigned this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants