Fixed error messages not printing to terminal

[yathartha3]

Currently, some ROS2 node exception handling error messages are not being printed to the terminal because the print command was commented out. I have removed the comments and it is working in my system (Ubuntu 18.04, with ROS2).
This will help the debugging process since now, the error messages will be visible.

[rotu]

Fixes #776

[rotu]

What’s the deal with that todo comment by @Karsten1987 ? Why was this code commented out in the first place?

[jacobperron]

Let's see if Windows likes it:

[jacobperron]

Strange. CI for Windows interprets the error message (which is correctly produced in the test output) as a build warning. This likely what the TODO is about.

[rotu]

That must be what the todo comment meant. :-/

[yathartha3]

Removed the "\n" characters from the log message

[jacobperron]

Removed the "\n" characters from the log message

Thanks, unfortunately it looks like the build warning persists.

[rotu]

Just change "Original error msg:" to "Original error" and you should be good.

Also, we should file an upstream bug against ros2/ci. The Jenkins warnings plugin responsible for this CI failure is deprecated. Edit: ✅issues filed

I was able to reproduce the problem with this regex tester:
https://www.regexplanet.com/advanced/java/index.html

Put this in the "regular expression" field:

(?:^(?:.*)Command line warning ([A-Za-z0-9]+):\s*(.*)\s*\[(.*)\])|^(?:.*\[.*\])?\s*(?:(?:\s*\d+>)?(?:(?:(?:(.*)\((\d*)(?:,(\d+))?.*\)|.*LINK)\s*:|(.*):)\s*([A-z-_]*\s?(?:[Nn]ote|[Ii]nfo|[Ww]arning|(?:fatal\s*)?[Ee]rror))\s*:?\s*([A-Za-z0-9]+)\s*:\s(?:\s*([A-Za-z0-9.]+)\s*:)?\s*(.*?)(?: \[([^\]]*)[/\\][^\]\\]+\])?|(.*)\s*:.*error\s*(LNK[0-9]+):\s*(.*)))$

Check the "^ and $ match EOL (MULTILINE)" field.
And put this in input 1:

4: [==========] Running 4 tests from 1 test case.
4: [----------] Global test environment set-up.
4: [----------] 4 tests from TestCallbackExceptions
4: [ RUN      ] TestCallbackExceptions.positive_on_error
4: [ERROR] []: Caught exception in callback for transition 10
4: 
4: [ERROR] []: Original error msg: custom exception raised in configure callback
4: 
4: [WARN] []: Error occurred while doing error handling.
4: [       OK ] TestCallbackExceptions.positive_on_error (26 ms)

[jacobperron]

@rotu Nice, thanks for looking into it!

[jacobperron]

• Linux
• Linux-aarch64
• macOS
• Windows

[rotu]

The suspense is killing me
HUZZAH! 🎆