Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashing backport] Fixed error messages not printing to terminal (#777) #847

Merged
merged 1 commit into from
Sep 5, 2019
Merged

[dashing backport] Fixed error messages not printing to terminal (#777) #847

merged 1 commit into from
Sep 5, 2019

Conversation

jacobperron
Copy link
Member

Backport #777

@yathartha3 @jacobperron
Fixe error messages not printing to terminal (#777)
355b671 
* Uncommented catch exception code to print error

Signed-off-by: Yathartha Tuladhar <yathartha3@gmail.com>

* put back the e

Signed-off-by: Yathartha Tuladhar <yathartha3@gmail.com>

* uncommented error printing in exception handling

Signed-off-by: Yathartha Tuladhar <yathartha3@gmail.com>

* Removed "/n" characters.
Update lifecycle_node_interface_impl.hpp

Signed-off-by: Yathartha Tuladhar <yathartha3@gmail.com>

* Fix CI issue and remove TODO

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 25eeffd into dashing Sep 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/backport_777 branch September 5, 2019 18:59
@rotu rotu mentioned this pull request Sep 27, 2019
Closed
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
@lihui815
keyboard controls for pause/resume toggle and play-next: (ros2#847)
6173fe1 
* adds keyboard controls for ros2 bag play

Signed-off-by: Sonia Jin <diegothemuich@gmail.com>
Co-authored-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @sloretz @yathartha3