Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eloquent backport] Complete published event message when declaring a parameter (#928) #966

Merged
merged 1 commit into from Jan 31, 2020
Merged

[eloquent backport] Complete published event message when declaring a parameter (#928) #966

merged 1 commit into from Jan 31, 2020

Conversation

jacobperron
Copy link
Member

Backport #928 to Eloquent.

@ivanpauno @jacobperron
Complete published event message when declaring a parameter (#928)
4f61268 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@jacobperron jacobperron added this to Needs Release in Eloquent Patch Release 1 Jan 17, 2020
@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

1 similar comment
@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Member Author

We see different test failures each time I trigger the PR job... 😞 I guess they're flakey tests that are unrelated.

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Member Author

jacobperron commented Jan 17, 2020 •
edited

The PR job seems unreliable, triggering CI instead:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron removed this from Needs Release in Eloquent Patch Release 1 Jan 18, 2020
@jacobperron jacobperron added this to Needs Release in Eloquent Patch Release 2 Jan 18, 2020
ivanpauno
ivanpauno approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@jacobperron is this ready to be merged?

@jacobperron
Copy link
Member Author

I held off on merging until I could see a green CI build for the PR job. I can try again 🤷‍♂️

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron jacobperron merged commit ef788db into eloquent Jan 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/backport_928 branch January 31, 2020 01:15
@mjcarroll mjcarroll moved this from Needs Release to Released in Eloquent Patch Release 2 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Eloquent Patch Release 2
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobperron @mjcarroll @ivanpauno