[rclcpp_action] removed rosidl_generator_c dependency #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
lgtm, with CI.
I'd like @jacobperron to have a look too, just in case we're missing something he sees.
jacobperron
reviewed
Feb 14, 2020
…endencies Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/dependency/rclcpp_action
branch
from
f52a5f0
to
1e852aa
Compare
|
should I run the CI? |
|
Please check the sources of the package. Again, as in other similar PRs, the package uses symbols from the proposed-to-be-removed dependency: |
|
Yes, I would expect CI to catch things like Dirk pointed out. |
Not necessarily if other dependencies bring the needed dependency in transitively. |
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
dirk-thomas
reviewed
Feb 14, 2020
| "rosidl_generator_c" | ||
| "rosidl_generator_cpp") | ||
| "rclcpp" |
There was a problem hiding this comment.
Nitpick: revert order change.
ahcorde
changed the title
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
|
|
|
|
Unrelated failures. Merging it |
delete-merged-branch
bot
deleted the
ahcorde/dependency/rclcpp_action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing yesterday with @wjwwood we think that these dependencies are not needed anymore here.
I compiled from sources master and I executed the action examples and it's working