Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use serialized message (#1081)" #1090

Closed
wants to merge 1 commit into from

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Apr 23, 2020

@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Apr 23, 2020
@ivanpauno ivanpauno self-assigned this Apr 23, 2020
This reverts commit 46cfe84.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

ivanpauno commented Apr 23, 2020

CI config:

  • build: --packages-up-to test_communication
  • test: --packages-select test_communication --ctest-args -R test_publisher_subscriber_serialized__rmw_connext_cpp (that one is the test that is hanging)

Jobs:

  • Linux Build Status

@j-rivero
Copy link

I've verified that test run at the end of the #1081 (comment) did not run test_communication package. That is why it was not triggered during the PR testing and appeared in the new builds.

@j-rivero
Copy link

@Karsten1987 is working on a proper fix for the communication tests. Hopefully we don't need to revert.

@ivanpauno
Copy link
Member Author

ivanpauno commented Apr 23, 2020

@Karsten1987 The job above confirms that this unblocks CI.
I will left the decision to you if going ahead with these reverts or merging a fix.

(edit) If you need some reviews you can ping me.

@Karsten1987
Copy link
Contributor

Karsten1987 commented Apr 23, 2020

I just linked two PRs which should fix this:

build all, test only test_communication:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status

@Karsten1987

This comment has been minimized.

@dirk-thomas

This comment has been minimized.

@ivanpauno ivanpauno closed this Apr 23, 2020
@ivanpauno
Copy link
Member Author

Closed in favor of #1092 and ros2/system_tests#427.

@ivanpauno ivanpauno deleted the ivanpauno/revert-#1081 branch April 23, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants