-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Use serialized message (#1081)" #1090
Conversation
This reverts commit 46cfe84. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
985a981
to
e590bdc
Compare
I've verified that test run at the end of the #1081 (comment) did not run test_communication package. That is why it was not triggered during the PR testing and appeared in the new builds. |
@Karsten1987 is working on a proper fix for the communication tests. Hopefully we don't need to revert. |
@Karsten1987 The job above confirms that this unblocks CI. (edit) If you need some reviews you can ping me. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closed in favor of #1092 and ros2/system_tests#427. |
Reverts #1081.
Requires ros2/rosbag2#389 and ros2/demos#443.
Lots of jobs hanging in
test_communication
: