Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include original exception in ComponentManagerException #1157

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Include original exception in ComponentManagerException #1157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e76460
Include original exception in ComponentManagerException
mbuijs Jun 8, 2020
668959f
Update rclcpp_components/src/component_manager.cpp
mbuijs Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rclcpp_components/src/component_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,11 @@ ComponentManager::OnLoadNode(

try {
node_wrappers_[node_id] = factory->create_node_instance(options);
} catch (const std::exception & ex) {
// In the case that the component constructor throws an exception,
// rethrow into the following catch block.
throw ComponentManagerException(
"Component constructor threw an exception: " + std::string(ex.what()));
} catch (...) {
// In the case that the component constructor throws an exception,
// rethrow into the following catch block.
Expand Down