Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foxy Backport] Include original exception in ComponentManagerException (#1157) #1223

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

dawonn-haval
Copy link

  • Include original exception in ComponentManagerException

Signed-off-by: Martijn Buijs martijn.buijs@gmail.com

  • Update rclcpp_components/src/component_manager.cpp

Co-authored-by: tomoya Tomoya.Fujita@sony.com
Signed-off-by: Martijn Buijs martijn.buijs@gmail.com

Co-authored-by: tomoya Tomoya.Fujita@sony.com

* Include original exception in ComponentManagerException

Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

* Update rclcpp_components/src/component_manager.cpp

Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
@dirk-thomas dirk-thomas added this to Proposed in Foxy Patch Release 2 via automation Aug 6, 2020
@jacobperron jacobperron removed this from Proposed in Foxy Patch Release 2 Aug 7, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 3 via automation Aug 7, 2020
@jacobperron jacobperron moved this from Proposed to Needs release in Foxy Patch Release 3 Aug 7, 2020
@jacobperron
Copy link
Member

@dawonn-haval Thanks for the backport!

@jacobperron jacobperron merged commit cb1b32e into ros2:foxy Oct 1, 2020
@dawonn-haval dawonn-haval deleted the cherry-pick-1157 branch October 1, 2020 19:43
@jacobperron jacobperron moved this from Needs release to Released in Foxy Patch Release 3 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants