Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include topic name in QoS mismatch warning messages #1286

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Include topic name in QoS mismatch warning messages #1286

merged 5 commits into from
Sep 23, 2020

Commits on Sep 10, 2020

  1. Include topic name in QoS mismatch warning messages 

    Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
    @codebot
    codebot committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    211faa0 View commit details
    Browse the repository at this point in the history

  2. simplify 

    Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
    @codebot
    codebot committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    4d33bc2 View commit details
    Browse the repository at this point in the history

  3. Update rclcpp/src/rclcpp/publisher_base.cpp 

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
    @codebot @clalancette
    codebot and clalancette committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    31f04ae View commit details
    Browse the repository at this point in the history

  4. add quotes for QoS mismatch topic name error string 

    Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
    @codebot
    codebot committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    a67ae22 View commit details
    Browse the repository at this point in the history

  5. update expected error message in QoS test 

    Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
    @codebot
    codebot committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    66e34fa View commit details
    Browse the repository at this point in the history