Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy] Fix implementation of NodeOptions::use_global_arguments() (#1176) #1372

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[foxy] Fix implementation of NodeOptions::use_global_arguments() (#1176) #1372

merged 1 commit into from
Oct 6, 2020

Conversation

jacobperron
Copy link
Member

Backport #1176 to Foxy.

@meyerj @jacobperron
Fix implementation of NodeOptions::use_global_arguments() (#1176)
0a4847a 
`this->node_options_` might still be `nullptr` for a default initialized NodeOptions instance.
`use_global_arguments()` must return `this->use_global_arguments_`, in analogy to `NodeOptions::enable_rosout()`.

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 3 via automation Oct 2, 2020
@jacobperron jacobperron moved this from Proposed to Needs release in Foxy Patch Release 3 Oct 2, 2020
@jacobperron jacobperron merged commit 4dcb0ed into foxy Oct 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/backport_foxy_1176 branch October 6, 2020 18:33
@jacobperron jacobperron moved this from Needs release to Released in Foxy Patch Release 3 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Foxy Patch Release 3
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobperron @ivanpauno @meyerj