Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rclcpp_lifecycle] Change uint8_t iterator variables to size_t #1461

Merged
merged 2 commits into from
Nov 17, 2020
Merged

[rclcpp_lifecycle] Change uint8_t iterator variables to size_t #1461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a28c05
Change uint8_t iterator variables to size_t
brawner Nov 16, 2020
5320559
Change to unsigned int
brawner Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ class LifecycleNode::LifecycleNodeInterfaceImpl
throw std::runtime_error(
"Can't get available states. State machine is not initialized.");
}
for (uint8_t i = 0; i < state_machine_.transition_map.states_size; ++i) {
for (unsigned int i = 0; i < state_machine_.transition_map.states_size; ++i) {
lifecycle_msgs::msg::State state;
state.id = static_cast<uint8_t>(state_machine_.transition_map.states[i].id);
state.label = static_cast<std::string>(state_machine_.transition_map.states[i].label);
Expand All @@ -286,7 +286,7 @@ class LifecycleNode::LifecycleNodeInterfaceImpl
"Can't get available transitions. State machine is not initialized.");
}

for (uint8_t i = 0; i < state_machine_.current_state->valid_transition_size; ++i) {
for (unsigned int i = 0; i < state_machine_.current_state->valid_transition_size; ++i) {
auto rcl_transition = state_machine_.current_state->valid_transitions[i];
lifecycle_msgs::msg::TransitionDescription trans_desc;
trans_desc.transition.id = static_cast<uint8_t>(rcl_transition.id);
Expand All @@ -312,7 +312,7 @@ class LifecycleNode::LifecycleNodeInterfaceImpl
"Can't get available transitions. State machine is not initialized.");
}

for (uint8_t i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
for (unsigned int i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
auto rcl_transition = state_machine_.transition_map.transitions[i];
lifecycle_msgs::msg::TransitionDescription trans_desc;
trans_desc.transition.id = static_cast<uint8_t>(rcl_transition.id);
Expand All @@ -336,7 +336,7 @@ class LifecycleNode::LifecycleNodeInterfaceImpl
get_available_states()
{
std::vector<State> states;
for (uint8_t i = 0; i < state_machine_.transition_map.states_size; ++i) {
for (unsigned int i = 0; i < state_machine_.transition_map.states_size; ++i) {
State state(&state_machine_.transition_map.states[i]);
states.push_back(state);
}
Expand All @@ -348,7 +348,7 @@ class LifecycleNode::LifecycleNodeInterfaceImpl
{
std::vector<Transition> transitions;

for (uint8_t i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
for (unsigned int i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
Transition transition(
&state_machine_.transition_map.transitions[i]);
transitions.push_back(transition);
Expand Down