Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in a fix for older compilers. #2075

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Add in a fix for older compilers. #2075

merged 2 commits into from
Jan 4, 2023

Commits on Jan 2, 2023

  1. Add in a fix for older compilers. 

    The addition of the NodeInterfaces class made it stop compiling
with older compilers (such as gcc 9.4.0 on Ubuntu 20.04).
The error has to do with calling the copy constructor on
rclcpp::Node, which is deleted.  Work around this by just
getting rid of the nullptr check; it isn't actually needed,
I don't think.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    c8cab3e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Remove the NodeInterfaces shared_ptr constructor. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    53bc8ab View commit details
    Browse the repository at this point in the history