Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is directly linked to issue #2073 which discusses the volubility of the the goal id in the async_send_goal. So far the thread has come to the conclusion that well-formed uuids should be implemented in accordance to RFC 4122 which may have been solved in pull request #1999, by converting to the appropriate string. Otherwise we must follow a representation of bit shifting seen in many examples.
Since the RFC issue may have already been addressed to formulate valuable UUIDs at version 4, I then added an overloaded function of
async_send_goal
which allows the user to add their own UUID. This is a double edged sword, depending on the way the user generates a UUID. Technically speaking, if the user has another UUID it could use a generator different from the one called in the method, so it is slightly dangerous to have both of these generators mix. This is only if the UUIDs end up being reserved already, but there so many combinations that this shouldn't happen, still a slight chance though. Conversely it can act very smoothly when the user continuesly uses their own generator for whatever reason they choose. In this case I feel that the unlikely chance of duplication in exchange for user comfortability justifies a overloaded method.