Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding API to copy all parameters from one node to another #2304

Merged
merged 16 commits into from
Oct 5, 2023
Merged

Adding API to copy all parameters from one node to another #2304

merged 16 commits into from
Oct 5, 2023

Commits on Sep 12, 2023

  1. adding API to copy all parameters from one node to another 

    Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
    @SteveMacenski
    SteveMacenski committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    89488b9 View commit details
    Browse the repository at this point in the history

  2. adding API docs portion on rclcpp/rclcpp.hpp 

    Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
    @SteveMacenski
    SteveMacenski committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b258b8f View commit details
    Browse the repository at this point in the history

  3. adding override option to copy_all_parameters() + review comments 

    Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
    @SteveMacenski
    SteveMacenski committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8614994 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. updating for requested changes: test structure update and using node … 

    …parameter interface APIs

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
    @SteveMacenski
    SteveMacenski committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    dd0453e View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. adding requested updates from Tomoya 

    Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
    @SteveMacenski
    SteveMacenski committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4adc36d View commit details
    Browse the repository at this point in the history

  2. adding unit tests for negative cases 

    Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
    @SteveMacenski
    SteveMacenski committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f33f9a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. rename to copy_all_paramter_values 

    Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
    @SteveMacenski
    SteveMacenski committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    2e2f84e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. fix the depth to relative in list_parameters (ros2#2300) 

    * fix the depth to relative in list_parameters

Signed-off-by: leeminju531 <dlalswn531@naver.com>
    @leeminju531 @SteveMacenski
    leeminju531 authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    0aa6f31 View commit details
    Browse the repository at this point in the history

  2. Decouple rosout publisher init from node init. (ros2#2174) 

    Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya @SteveMacenski
    fujitatomoya authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    44fffbd View commit details
    Browse the repository at this point in the history

  3. Documentation for list_parameters (ros2#2315) 

    * list_parameters documentation

Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
    @CursedRock17 @SteveMacenski
    CursedRock17 authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    f3ba9b4 View commit details
    Browse the repository at this point in the history

  4. Removing Old Connext Tests (ros2#2313) 

    * Removing Old Connext Tests

Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
    @CursedRock17 @SteveMacenski
    CursedRock17 authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ec3a3f4 View commit details
    Browse the repository at this point in the history

  5. Update SignalHandler get_global_signal_handler to avoid complex types… 

    … in static memory (ros2#2316)

* Update SignalHandler get_global_signal_handler to avoid complex types in static memory

This was flagged by msan as a problem.

There's a description of why this is a potential problem here: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai>
Co-authored-by: William Woodall <william+github@osrfoundation.org>
    @tfoote @wjwwood @SteveMacenski
    2 people authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    71c691e View commit details
    Browse the repository at this point in the history

  6. Add locking to protect the TimeSource::NodeState::node_base_ (ros2#2320) 

    We need this because it is possible for one thread to
be handling the on_parameter_event callback while another
one is detaching the node.  This lock will protect that
from happening.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette @SteveMacenski
    clalancette authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d0be8ad View commit details
    Browse the repository at this point in the history

  7. Add missing header required by the rclcpp::NodeOptions type (ros2#2324) 

    Signed-off-by: Ignacio Vizzo <ignacio@dexory.com>
    @nachovizzo @SteveMacenski
    nachovizzo authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e284387 View commit details
    Browse the repository at this point in the history

  8. Changelog. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette @SteveMacenski
    clalancette authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    12018db View commit details
    Browse the repository at this point in the history

  9. 23.1.0

    @clalancette @SteveMacenski
    clalancette authored and SteveMacenski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    7dd2d62 View commit details
    Browse the repository at this point in the history