Warn unused #327
Merged
Warn unused #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
May 24, 2017
| @@ -0,0 +1,55 @@ | |||
| // Copyright 2015 Open Source Robotics Foundation, Inc. | |||
| EXPECT_EQ(3, c_state2.id()); | ||
| EXPECT_FALSE(c_state2.label().empty()); | ||
| ASSERT_STREQ("my_c_state2", c_state2.label().c_str()); | ||
| // introduces flakiness |
There was a problem hiding this comment.
Is this ticketed somewhere ? or should we add a TODO here to remember that there is a commented out test?
There was a problem hiding this comment.
The commented out test is on purpose. When compiling with actual memory sanitizer, this last tests fails and thus produces a flaky test.
|
BTW: really like the description text of this PR 😄 |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Adding new cli parameters for configuring the logging. cr https://code.amazon.com/reviews/CR-3728503 * Moving the external logger library from rcutils into rcl. Also automatic uncrustify. * Fixing issue with rebase * Temporarily switching the default to noop logger ext_lib while system dependency issue is solved for Windows/Mac. * Fixing the format2/3 xmllint issue. * style changes, and one actual fix Signed-off-by: William Woodall <william@osrfoundation.org> * rename rc_logging* to rcl_logging* Signed-off-by: William Woodall <william@osrfoundation.org> * Expand rcl_logging_configure API with allocator This is to make sure that this API is complete, and we can merge rcl#350 later without breaking the API at a later date. * update logging.c with new use of allocator in API * update init.c with new API changes * Switching back to va_list for output handlers. * address review comments Signed-off-by: William Woodall <william@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flakiness