Allow creating parameter client from constructor of Node subclass #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example usage in https://github.com/ros2/demos/pull/203/files#diff-653dd97d51d2e5cbd57891eb644a8654R26 (note that the parameter server is still created after the node has been instantiated. We could make it possible from the constructor, but I was avoiding adding API we'd likely remove later on. |
|
I'm putting this into review because I've successfully tested ros2/demos#203 that makes use of this (see ros2/demos#203 (comment)) |
dhood
commented
Dec 3, 2017
| @@ -63,6 +63,12 @@ class AsyncParametersClient | |||
| const std::string & remote_node_name = "", | |||
| const rmw_qos_profile_t & qos_profile = rmw_qos_profile_parameters); | |||
|
|
|||
| RCLCPP_PUBLIC | |||
| AsyncParametersClient( | |||
| rclcpp::node::Node * node, | |||
There was a problem hiding this comment.
note that this is not const because things like node->get_node_base_interface() are not
wjwwood
approved these changes
Dec 3, 2017
dhood
added
in review
|
yeah, but waffle doesn't propagate the label to connected tickets sometimes |
dhood
added a commit
to ros2/system_tests
that referenced
this pull request
Dec 4, 2017
dhood
added a commit
to ros2/system_tests
that referenced
this pull request
Dec 4, 2017
* Add regression test for set_parameters with callback * Make it like the parameter_events_async node to excercise the bad reference * Create paramters_client_ in constructor of node subclass Possible since ros2/rclcpp#413
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409
I only did this for parameter clients: parameter services still need to be created outside of the constructor, but this is not something that we expect users to have to do manually in the long term.