Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ParameterVariant into Parameter and ParameterValue #481

Merged
merged 17 commits into from
Jun 1, 2018
Merged

Split ParameterVariant into Parameter and ParameterValue #481

merged 17 commits into from
Jun 1, 2018

Commits on May 25, 2018

  1. Moved ParameterType + started ParameterValue

    @sloretz
    sloretz committed May 25, 2018
    Configuration menu
    Copy the full SHA
    9e9f37c View commit details
    Browse the repository at this point in the history

Commits on May 29, 2018

  1. Delegate get_value() to ParameterValue 

    Test expects ParameterTypeException
    @sloretz
    sloretz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    ee1230a View commit details
    Browse the repository at this point in the history

  2. Remove as_*() from ParameterValue

    @sloretz
    sloretz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    fa8f19e View commit details
    Browse the repository at this point in the history

  3. Remove unused includes

    @sloretz
    sloretz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    6d51a66 View commit details
    Browse the repository at this point in the history

  4. get_parameter_value() -> get_value_message()

    @sloretz
    sloretz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    a79730e View commit details
    Browse the repository at this point in the history

  5. rclcpp::parameter::ParameterVariant -> rclcpp::Parameter

    @sloretz
    sloretz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    6c441ca View commit details
    Browse the repository at this point in the history

  6. Add missing rclcpp::

    @sloretz
    sloretz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    e182a0b View commit details
    Browse the repository at this point in the history

  7. array_to_string exists on ParameterValue

    @sloretz
    sloretz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    798880b View commit details
    Browse the repository at this point in the history

  8. Make to_parameter() const

    @sloretz
    sloretz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    69f3421 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2018

  1. Remove RCLCPP_PUBLIC before definition

    @sloretz
    sloretz committed May 30, 2018
    Configuration menu
    Copy the full SHA
    895bd4c View commit details
    Browse the repository at this point in the history

  2. Add RCLCPP_PUBLIC to methods

    @sloretz
    sloretz committed May 30, 2018
    Configuration menu
    Copy the full SHA
    f002629 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2018

  1. ParameterTypeException inherit from runtime_error

    @sloretz
    sloretz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    a289f63 View commit details
    Browse the repository at this point in the history

  2. decltype(auto) return type

    @sloretz
    sloretz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    f8646d0 View commit details
    Browse the repository at this point in the history

  3. consistent doc block

    @sloretz
    sloretz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    bea1335 View commit details
    Browse the repository at this point in the history

  4. Minor comment fixes

    @sloretz
    sloretz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    374b81a View commit details
    Browse the repository at this point in the history

  5. Add ParameterValue to main API comment

    @sloretz
    sloretz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    18555dc View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2018

  1. to_parameter_msg() from_parameter_msg() 

    to_value_msg()
    @sloretz
    sloretz committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    22d89b9 View commit details
    Browse the repository at this point in the history