Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully delete parameters #489

Merged
merged 2 commits into from
Jun 4, 2018
Merged

fully delete parameters #489

merged 2 commits into from
Jun 4, 2018

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Jun 1, 2018 •
edited
Loading

Fixes #487.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Jun 1, 2018
@dirk-thomas dirk-thomas self-assigned this Jun 1, 2018
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 4, 2018
Merged
@sloretz
Copy link
Contributor

sloretz commented Jun 4, 2018

OSX failure has java stack trace. Looks like the restarted job succeeded Build Status

@dirk-thomas dirk-thomas merged commit 5ab6bde into master Jun 4, 2018
@dirk-thomas dirk-thomas deleted the fully_delete_parameters branch June 4, 2018 22:06
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dirk-thomas @sloretz @tfoote