Add max_duration to spin_some() #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With max_duration spin_some will execute work until it has spent more time than the elapsed duration.
sloretz
added
enhancement
This was referenced Sep 15, 2018
wjwwood
approved these changes
Sep 17, 2018
dirk-thomas
reviewed
Sep 17, 2018
| */ | ||
| RCLCPP_PUBLIC | ||
| virtual void | ||
| spin_some(); | ||
| spin_some(std::chrono::nanoseconds max_duration = std::chrono::nanoseconds(0)); |
There was a problem hiding this comment.
Would timeout match existing naming better?
There was a problem hiding this comment.
I think the behavior is different. I would expect timeout to mean the function blocks until that amount of time elapses, but this function will return immediately when no work is available regardless of max_duration.
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Miaofei <miaofei@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter to
spin_some()for the maximum duration to spend executing work. It preventsspin_some()from blocking forever if there are always callbacks ready. The reason for adding it is to allow rviz to execute all callbacks without being limited by the gui or blocking it.connects to ros2/ros1_bridge#133
Blocks ros2/rviz#354
CI ros2/rviz#354 (comment)