Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added count matching api and intra-process subscriber count #628
Added count matching api and intra-process subscriber count #628
Changes from all commits
5b8bae0
16d1a76
be7492b
9c9ba34
11e37e1
cbd7240
490a6f4
cd556df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanpauno well, the publisher isn't necessarily using intra-process communication. We need another flag to know whether this should log an error or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is called in the destructor, it could happens that the ipm have already gone out of the scope first (I'm not sure, but it sounds reasonable). So, I don't think rising an error is a good idea.
If we want to raise an error, we need an extra flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanpauno Looks like here we should be using the
use_intra_process_
flag as well to know whether this should be treated as an error or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanpauno I'm not sure this is the right thing to do. Correct me if I'm wrong, but wouldn't
ipm
benullptr
if the publisher was not setup to use intra-process communication? Even if we think that throwing is better than returning 0, the exception message may be misleading.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes right, I will check again. Maybe adding an extra flag as commented before.