Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing template functionality to lifecycle_node. #707

Merged
merged 8 commits into from
May 15, 2019
Merged

Add missing template functionality to lifecycle_node. #707

merged 8 commits into from
May 15, 2019

Commits on May 14, 2019

  1. Add missing template functionality to lifecycle_node. 

    Recent changes to the node_parameters interface was accompanied by additions to the
node.hpp header and implementation files. However, these additions were not also made
to the corresponding lifecycle node files. This PR includes the changes required for
the lifecycle node.

Going forward, I suggest that any code like this that supplements the basic node interfaces
should either be factored out into a separate header that both node and lifecycle_node
include, or that the supplemental code simply be included in the appropriate node_interface
file directly, if possible. That way we can avoid code duplication and its symptoms which
is node and lifecycle_node getting out of sync (which they have several times).

Signed-off-by: Michael Jeronimo <michael.jeronimo@intel.com>
    Michael Jeronimo committed May 14, 2019
    Configuration menu
    Copy the full SHA
    d1500b5 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. consolidate documentation to just be in rclcpp/node.hpp 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 15, 2019
    Configuration menu
    Copy the full SHA
    afe5228 View commit details
    Browse the repository at this point in the history

  2. fix visibility macros 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 15, 2019
    Configuration menu
    Copy the full SHA
    05f2470 View commit details
    Browse the repository at this point in the history

  3. deprecation methods that were also deprecated in rclcpp::Node 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 15, 2019
    Configuration menu
    Copy the full SHA
    10684ea View commit details
    Browse the repository at this point in the history

  4. fixup variable name 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 15, 2019
    Configuration menu
    Copy the full SHA
    1bdf771 View commit details
    Browse the repository at this point in the history

  5. add missing template method implementations 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 15, 2019
    Configuration menu
    Copy the full SHA
    541506e View commit details
    Browse the repository at this point in the history

  6. add more methods that were not ported to lifecycle node originally 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 15, 2019
    Configuration menu
    Copy the full SHA
    78cc912 View commit details
    Browse the repository at this point in the history

  7. fix cpplint 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 15, 2019
    Configuration menu
    Copy the full SHA
    58989fd View commit details
    Browse the repository at this point in the history