Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ParameterEventsSubscriber class #829

Merged
merged 31 commits into from
Mar 4, 2021
Merged

Add ParameterEventsSubscriber class #829

merged 31 commits into from
Mar 4, 2021

Commits on Nov 30, 2020

  1. add ParameterEventsSubscriber class and tests 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    6473041 View commit details
    Browse the repository at this point in the history

  2. test improvements, path name fixes, and more documentation 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    3246e34 View commit details
    Browse the repository at this point in the history

  3. fix lint and uncrustify issues 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    cdf4156 View commit details
    Browse the repository at this point in the history

  4. add try-catch and warning around getting parameter value 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    72817ab View commit details
    Browse the repository at this point in the history

  5. pass rclcpp::Parameter object to callback, rename functions, get para… 

    …m from event

Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    884a2d8 View commit details
    Browse the repository at this point in the history

  6. use unordered map with string pair, add test for different nodes same… 

    … parameter, address feedback

Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    f189327 View commit details
    Browse the repository at this point in the history

  7. address feedback (wjwwood) part 1 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>

use const string & for node name

Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    a010d2d View commit details
    Browse the repository at this point in the history

  8. add RCLCPP_PUBLIC macro 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    f67d829 View commit details
    Browse the repository at this point in the history

  9. address feedback part 1: static get_parameter method, remove register… 

    …_parameter_update, mutex for thread-safety

Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    12329bf View commit details
    Browse the repository at this point in the history

  10. map parameters to list of callbacks 

    functions to remove parameter callbacks

add functions to remove event callbacks, remove subscriptions, allow subscribing event callback to many namespaces, additional test coverage

Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    921d2b4 View commit details
    Browse the repository at this point in the history

  11. use absolute parameter event topic for parameter event subscriber 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    7c19dbb View commit details
    Browse the repository at this point in the history

  12. support multiple parameter event callbacks 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    9cc41c7 View commit details
    Browse the repository at this point in the history

  13. use get_child for parameter event subscriber logger 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    2559434 View commit details
    Browse the repository at this point in the history

  14. update utility function description 

    Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    0d5d75c View commit details
    Browse the repository at this point in the history

  15. address feedback: move HandleCompare, test exceptions, reference code… 

    … source

Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    e4bc1d8 View commit details
    Browse the repository at this point in the history

  16. address feedback: replace ParameterEventsFilter dependency, fix copyr… 

    …ight, add get_node_logging_interface, modify constructor

Signed-off-by: bpwilcox <bpwilcox@eng.ucsd.edu>
    @mjeronimo
    bpwilcox authored and mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    f360350 View commit details
    Browse the repository at this point in the history

  17. Get rid of a few compiler warnings; add test to build 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    36e0190 View commit details
    Browse the repository at this point in the history

  18. Remove some unneeded code 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    e41f75c View commit details
    Browse the repository at this point in the history

  19. Remove a stray debug trace 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    b3b683f View commit details
    Browse the repository at this point in the history

  20. Add a function to get all parameter values from a parameter event 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    8fb32de View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Address code review feedback 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    60533db View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Merge pull request #1 from mjeronimo/mjeronimo/address-review-feedback 

    Address code review feedback
    bpwilcox authored Jan 8, 2021
    Configuration menu
    Copy the full SHA
    ab4ff32 View commit details
    Browse the repository at this point in the history

  2. Another name change; using Handler instead of the more passive term, … 

    …Monitor

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    894da98 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from mjeronimo/mjeronimo/address-review-feedback 

    Another name change; using Handler instead of the more passive term, …
    bpwilcox authored Jan 8, 2021
    Configuration menu
    Copy the full SHA
    3404ec9 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Pass SharedPtrs callback remove functions instead of bare pointers 

    Per William's review feedback.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d4128de View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Merge pull request #3 from mjeronimo/mjeronimo/address-review-feedback 

    Pass SharedPtrs callback remove functions instead of bare pointers
    bpwilcox authored Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1201f4f View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Add a comment block describing usage 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    18e72cf View commit details
    Browse the repository at this point in the history

  2. Address review feedback 

    * Remove unused interfaces
* Document LIFO order for invoking callbacks
* Add test cases to verify LIFO order for callbacks

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    e08612c View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4 from mjeronimo/mjeronimo/add-block-comment 

    Address review feedback
    bpwilcox authored Feb 11, 2021
    Configuration menu
    Copy the full SHA
    a4f5533 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. A couple more doc fixes from review comments 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    cbc8989 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Merge pull request #5 from mjeronimo/mjeronimo/add-block-comment 

    A couple more doc fixes from review comments
    bpwilcox authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    f011c3d View commit details
    Browse the repository at this point in the history