Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose logging macros in rclpy #103

Closed
dhood opened this issue Aug 22, 2017 · 2 comments
Closed

Expose logging macros in rclpy #103

dhood opened this issue Aug 22, 2017 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dhood
Copy link
Member

dhood commented Aug 22, 2017

meta-ticket.

First question: which usage do we want with respect to the severity:

  1. loginfo(...) (like in ROS 1)
  2. log(..., severity=INFO)

Second question: when considering the other logging variations, which do we want?

  1. log_info_throttle_named(...) (like the C usage)
  2. log_info(..., throttle_duration=1.0, name='my_name') (more pythonic IMO)
@dhood dhood added the enhancement New feature or request label Aug 22, 2017
@dhood dhood self-assigned this Aug 22, 2017
@dirk-thomas
Copy link
Member

We talked about this in the meeting:

Regarding the first question: use 2. log(..., severity=INFO) but offer 1. loginfo(...) for convenience.

Regarding the second question: the keyword argument (2.) is preferred.

Additionally it would be nice to have a get_named_logger(name='xxx') which can be called once and then be passed around. That logger could have log(..., severity=INFO) as well as info(...) for convenience.

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Aug 23, 2017
@dhood dhood added in review Waiting for review (Kanban column) in progress Actively being worked on (Kanban column) and removed in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) labels Sep 5, 2017
@mikaelarguedas
Copy link
Member

closing this now that #102 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants