Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include type hash in topic endpoint info (rep2011) #1104

Merged
merged 1 commit into from Jun 13, 2023
Merged

Include type hash in topic endpoint info (rep2011) #1104

merged 1 commit into from Jun 13, 2023

Conversation

achim-k
Copy link
Contributor

@achim-k achim-k commented Apr 3, 2023 •
edited

Part of ros2/ros2#1159

Features

  • Adds the TypeHash class
  • Adds the type hash to the TopicEndpointInfo class

This will print the type hash when printing out verbose topic information with rostopic info --verbose. Note that without the --no-daemon flag, ros2/ros2cli#816 is required which adds xmlrpc marshalling support for the new rclpy.type_hash.TypeHash class

@achim-k achim-k mentioned this pull request Apr 3, 2023
Merged
@achim-k achim-k changed the title Include type hash in topic endpoint info Include type hash in topic endpoint info (rep2011) Apr 3, 2023
emersonknapp
emersonknapp approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some small nitpicks you could address

rclpy/rclpy/type_hash.py Outdated Show resolved Hide resolved
rclpy/rclpy/type_hash.py Show resolved Hide resolved
rclpy/test/test_type_hash.py Outdated Show resolved Hide resolved
This was referenced Apr 11, 2023
Closed
Merged
@achim-k achim-k force-pushed the achim-k/rep2011_type_hash branch 2 times, most recently from 4200a55 to df8837a Compare April 13, 2023 20:02
clalancette
clalancette approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me.

@achim-k Am I correct in thinking that this one has no other dependencies? If that's the case, then I'll go ahead and run CI on it.

@achim-k
Copy link
Contributor Author

achim-k commented Jun 8, 2023

@achim-k Am I correct in thinking that this one has no other dependencies?

Yes, that's correct.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

@achim-k There were a bunch of test failures in here; can you take a look?

@achim-k
Copy link
Contributor Author

achim-k commented Jun 9, 2023

@achim-k Am I correct in thinking that this one has no other dependencies?

Yes, that's correct.

I was wrong. It depends on ros2/ros2cli#816 which adds marshalling support for the added TypeHash class. This is only required for runtime, but tests will fail without it.

@clalancette
Copy link
Contributor

I was wrong. It depends on ros2/ros2cli#816 which adds marshalling support for the added TypeHash class. This is only required for runtime, but tests will fail without it.

There also seems to be a flake8 issue in the tests, though it is in code that this doesn't touch. I'm going to rebase this to see if that improves the situation.

@achim-k @clalancette
Include type hash in topic endpoint info
0c94401 
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
@clalancette
Copy link
Contributor

New CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

It looks like there are still test failures.

@achim-k
Copy link
Contributor Author

achim-k commented Jun 9, 2023

It looks like there are still test failures.

Pushed a fix to ros2/ros2cli#816

@clalancette
Copy link
Contributor

All right, here is another CI run:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit ecf8958 into ros2:rolling Jun 13, 2023
3 checks passed
@clalancette
Copy link
Contributor

@Mergifyio backport iron

@mergify
Copy link

mergify bot commented Jun 13, 2023 •
edited

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 13, 2023
@achim-k @mergify
Include type hash in topic endpoint info (#1104)
626a20f 
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
(cherry picked from commit ecf8958)
@mergify mergify bot mentioned this pull request Jun 13, 2023
Merged
clalancette pushed a commit that referenced this pull request Jun 14, 2023
@mergify @achim-k
Include type hash in topic endpoint info (#1104) (#1134)
b53e413 
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
(cherry picked from commit ecf8958)

Co-authored-by: Hans-Joachim Krauch <achim-k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@emersonknapp emersonknapp emersonknapp approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achim-k @clalancette @emersonknapp