Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create classes inheriting from node without explicitly importing rclpy.node.Node #156

Open
mikaelarguedas opened this issue Nov 27, 2017 · 2 comments
Labels
enhancement New feature or request hitlist

Comments

@mikaelarguedas
Copy link
Member

To settle on before tagging the release.

Since #147, all classes inheriting from rclpy.Node need to explicitly import rclpy.node.Node (see ros2/demos#196).

It would be great to allow users to use that class without having to explicitly import it as it was the case before.

@dirk-thomas could you provide more information about the need of delaying importing the singleton and the possible alternatives to restore previous usability?

@mikaelarguedas mikaelarguedas added hitlist question Further information is requested labels Nov 27, 2017
@dirk-thomas
Copy link
Member

could you provide more information about the need of delaying importing the singleton and the possible alternatives to restore previous usability?

The import of the singleton needs to be delayed in order to allow to override the logic where it should be loaded from.

The Python module rclpy.node would need to be importable without importing rclpy.impl.implementation_singleton. Then it could be imported in the rclpy/__init__.py to make it accessible as before.

@dirk-thomas dirk-thomas removed the question Further information is requested label Dec 3, 2017
@dhood
Copy link
Member

dhood commented Dec 6, 2017

As a note: rclpy.logging is not being imported automatically either (it could be imported manually but it also imports a C extension and FWIU that's to be avoided): ros2/demos#210

@mikaelarguedas mikaelarguedas added the enhancement New feature or request label Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hitlist
Projects
None yet
Development

No branches or pull requests

3 participants