Check the rcl_action return value on cleanup. #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
clalancette
force-pushed
the
clalancette/check-rcl-action-retval
branch
from
0b305b9
to
7d44a99
Compare
sloretz
reviewed
Feb 1, 2021
And add an error message as appropriate. clang static analysis pointed out that this was a dead store. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
As sloretz pointed out, the pointer we were keeping to the original error would get overwritten with the next error, so we really need a copy. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/check-rcl-action-retval
branch
from
7d44a99
to
f3e340a
Compare
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
wjwwood
reviewed
Feb 2, 2021
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
wjwwood
approved these changes
Feb 3, 2021
|
CI:
|
|
All of the test failures are in the nightlies and don't have to do with this PR. Merging, thanks for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add an error message as appropriate. clang static
analysis pointed out that this was a dead store.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org