Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rclpy service functions to pybind11 #703

Merged
merged 6 commits into from
Mar 10, 2021
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 9, 2021

Part of #665

Converts:

  • rclpy_create_service
  • rclpy_send_response
  • rclpy_take_response

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay added the enhancement New feature or request label Mar 9, 2021
@cottsay cottsay requested a review from sloretz March 9, 2021 07:12
@cottsay cottsay self-assigned this Mar 9, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay
Copy link
Member Author

cottsay commented Mar 9, 2021

@ros-pull-request-builder retest this please

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay removed the enhancement New feature or request label Mar 9, 2021
@cottsay
Copy link
Member Author

cottsay commented Mar 9, 2021

@ros-pull-request-builder retest this please

I think the flaky tests are getting worse.

@cottsay cottsay mentioned this pull request Mar 9, 2021
34 tasks
@cottsay cottsay merged commit 2ed2746 into master Mar 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/pybind11_service branch March 10, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants