Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/duration to msg precision #876

Merged
merged 6 commits into from Jan 10, 2022
Merged

Bugfix/duration to msg precision #876

merged 6 commits into from Jan 10, 2022

Conversation

suurjaak
Copy link
Contributor

@suurjaak suurjaak commented Jan 7, 2022

Fixes #875.

DLu
DLu reviewed Jan 7, 2022
View reviewed changes
rclpy/rclpy/duration.py Outdated Show resolved Hide resolved
aprotyas
aprotyas reviewed Jan 7, 2022
View reviewed changes
rclpy/rclpy/duration.py Outdated Show resolved Hide resolved
iuhilnehc-ynos
iuhilnehc-ynos reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the rclpy.constants.S_TO_NS

rclpy/docs/source/api.rst Outdated Show resolved Hide resolved
clalancette
clalancette approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@suurjaak @clalancette
Fix rclpy.duration.Duration.to_msg() losing precision
48d72e5 
Signed-off-by: Erki Suurjaak <erki@lap.ee>
@suurjaak @clalancette
Add docstrings
ad35102 
Signed-off-by: Erki Suurjaak <erki@lap.ee>
@suurjaak @clalancette
Drop needless CONVERSION_CONSTANT
ffe8681 
Signed-off-by: Erki Suurjaak <erki@lap.ee>
@suurjaak @clalancette
Update docstring
9e9b7d1 
Signed-off-by: Erki Suurjaak <erki@lap.ee>
@suurjaak @clalancette
Make use of rclpy.constants.S_TO_NS
233b686 
Signed-off-by: Erki Suurjaak <erki@lap.ee>
@suurjaak @clalancette
Drop unintended change
479e32e 
Signed-off-by: Erki Suurjaak <erki@lap.ee>
@clalancette
Copy link
Contributor

FYI, I rebased and force-pushed this onto the latest so that I can get CI to run.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 289d7d3 into ros2:master Jan 10, 2022
@suurjaak suurjaak deleted the bugfix/duration_to_msg_precision branch January 10, 2022 18:45
@KOGDev KOGDev mentioned this pull request Mar 23, 2022
Open
@fujitatomoya
Copy link
Collaborator

@Mergifyio backport galactic

@fujitatomoya
Copy link
Collaborator

@Mergifyio backport foxy

mergify bot pushed a commit that referenced this pull request Mar 24, 2022
@suurjaak
Bugfix/duration to msg precision (#876)
ec14f68 
* Fix rclpy.duration.Duration.to_msg() losing precision

Signed-off-by: Erki Suurjaak <erki@lap.ee>
(cherry picked from commit 289d7d3)
@mergify mergify bot mentioned this pull request Mar 24, 2022
Merged
@mergify
Copy link

mergify bot commented Mar 24, 2022

backport galactic

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 24, 2022
@suurjaak
Bugfix/duration to msg precision (#876)
d52a4a3 
* Fix rclpy.duration.Duration.to_msg() losing precision

Signed-off-by: Erki Suurjaak <erki@lap.ee>
(cherry picked from commit 289d7d3)
@mergify mergify bot mentioned this pull request Mar 24, 2022
Merged
@mergify
Copy link

mergify bot commented Mar 24, 2022

backport foxy

✅ Backports have been created

sloretz pushed a commit that referenced this pull request Jun 10, 2022
@mergify @suurjaak
Bugfix/duration to msg precision (#876) (#917)
1bebfa2 
* Fix rclpy.duration.Duration.to_msg() losing precision

Signed-off-by: Erki Suurjaak <erki@lap.ee>
(cherry picked from commit 289d7d3)

Co-authored-by: Erki Suurjaak <erki@lap.ee>
sloretz pushed a commit that referenced this pull request Jun 10, 2022
@mergify @suurjaak
Bugfix/duration to msg precision (#876) (#916)
c76a6a1 
* Fix rclpy.duration.Duration.to_msg() losing precision

Signed-off-by: Erki Suurjaak <erki@lap.ee>
(cherry picked from commit 289d7d3)

Co-authored-by: Erki Suurjaak <erki@lap.ee>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DLu DLu DLu left review comments

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos left review comments

@clalancette clalancette clalancette approved these changes

@aprotyas aprotyas aprotyas approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rclpy.duration.Duration.to_msg() loses precision
6 participants
@suurjaak @clalancette @fujitatomoya @DLu @aprotyas @iuhilnehc-ynos