Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default number of threads of the MultiThreadedExecutor to 2 #1031

Merged

Conversation

fujitatomoya
Copy link
Collaborator

ros2/rclcpp#2030 for rclpy

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@clalancette can you take a look?

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

rclpy/rclpy/executors.py Outdated Show resolved Hide resolved
rclpy/rclpy/executors.py Outdated Show resolved Hide resolved
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small fixes for comments, then this will be good to go.

rclpy/rclpy/executors.py Outdated Show resolved Hide resolved
rclpy/rclpy/executors.py Outdated Show resolved Hide resolved
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@clalancette just fyi, ros2/rclcpp#2037 as follow-up for rclcpp

@fujitatomoya fujitatomoya merged commit 42397ad into ros2:rolling Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants