Reset the error when rcl_take_response failed. #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggangw
force-pushed
the
reset-errors
branch
from
27fafbd
to
3babf71
Compare
|
Thank you for the patch @minggangw. Actually Looking at this code, however, it seems that this section is missing an equivalent of https://github.com/ros2/rclcpp/pull/373/files in order to check the correct error message. If you have been seeing an error output when you didn't expect it, it may have been caused by that bug. The fix has been proposed in #143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[edit dhood]: connect to #142