Reset the error when rcl_take_response failed #396
Conversation
When the return value of rcl_take_response() is not equal to RCL_RET_OK, we need reset the error to avoid being overwritten.
There was a problem hiding this comment.
It's not really clear to me that we want to change this to an else statement. Looking through this file, the error check for all calls to rcl_take_* have a similar construction, and I'm assuming that is for a reason. Unfortunately I don't have enough context to know exactly what that reason is, but maybe someone else from @ros2/team has a better idea and can comment about it.
|
Thank you for the patch @minggangw
As mentioned in #397 (comment), the error message should actually not have been set by rcl in this situation, and then the clearing of the message in the client libraries will not be necessary. I'll close this PR for that reason. |
* decrease subscription expected msgs Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * change workflow to test this branch Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * change expected number too Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * linter Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * change workflow to autotest feature branch Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * revert workflow Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * run workflow more frequently to test stability Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * revert github workflow Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * cleanup Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * define constants Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * disable test on windows Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * disable play_filters_by_topic on windows Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
[edit dhood] connect to #397
When the return value of rcl_take_response() is not equal to RCL_RET_OK,
we need reset the error to avoid being overwritten.