Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset error message when rcl_take_response failed #142

Closed
minggangw opened this issue Nov 13, 2017 · 2 comments
Closed

Reset error message when rcl_take_response failed #142

minggangw opened this issue Nov 13, 2017 · 2 comments

Comments

@minggangw
Copy link

minggangw commented Nov 13, 2017 •
edited by dhood
Loading

[edit @dhood] connect to ros2/rclcpp#397

I noticed that the implement of rcl_take_response in rcl returns RCL_RET_ERROR and RCL_RET_CLIENT_TAKE_FAILED when the execution failed. So when this circumstance occurs, we should reset the error message to avoid being overwritten later. I have submitted a pr #141, PTAL thanks!
@minggangw minggangw mentioned this issue Nov 13, 2017
Closed
@dirk-thomas dirk-thomas mentioned this issue Nov 14, 2017
Merged
@dhood
Copy link
Member

dhood commented Nov 14, 2017

This is now essentially a duplicate of ros2/rclcpp#397 so I will close this issue. As mentioned in #141 (comment), if you were seeing unexpected error output then #143 may have fixed it for you.

@dhood dhood closed this as completed Nov 14, 2017
@minggangw
Copy link
Author

Thanks @dhood , that's reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhood @minggangw