Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable 100Hz timer test on windows #150

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Conversation

mikaelarguedas
Copy link
Member

now that we have better time resolution on windows these tests can be restored.

Unfortunately the 1kHz timer tests still fail and have to stay disabled.

  • Windows (rclpy tests ranusing --retest-until-fail 50) Build Status

@mikaelarguedas mikaelarguedas self-assigned this Nov 17, 2017
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 17, 2017
@serge-nikulin
Copy link

Unfortunately the 1kHz timer tests still fail and have to stay disabled.

Have you enabled 1KHz switching in Windows from the default 15ms or so?
AFAIK, MS has introduced this feature for gamers and it might help you.

@mikaelarguedas
Copy link
Member Author

@serge-nikulin Thanks for the tip,
I don't think we changed anything explicitly. Though if the default resolution is 15.6ms I would expect our 100Hz tests to fail, at least sporadically. I'll merge this for now and post an update here when I find time to explore that lead.

@mikaelarguedas mikaelarguedas merged commit 73e5137 into master Nov 17, 2017
@mikaelarguedas mikaelarguedas deleted the reenable_100hz_test branch November 17, 2017 18:47
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Nov 17, 2017
@serge-nikulin
Copy link

See https://msdn.microsoft.com/en-us/library/windows/desktop/dd757624(v=vs.85).aspx.
Call timeBeginPeriod at the startup time and don't bother to call timeEndPeriod at all.
A lot of airport security equipment around the world works in this mode for many years, non-stop, 24/365 :)

@mikaelarguedas
Copy link
Member Author

Good to know, thanks for the pointer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants