Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix executor.remove_node() #217

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Fix executor.remove_node() #217

merged 1 commit into from
Aug 8, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 8, 2018

executor.remove_node() was adding the node to executor._nodes instead of removing it. This PR fixes the function and adds a unit test.

@sloretz sloretz added bug Something isn't working in review Waiting for review (Kanban column) labels Aug 8, 2018
@sloretz sloretz self-assigned this Aug 8, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Aug 8, 2018

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

mikaelarguedas
mikaelarguedas approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
10Hz should be slow enough for us to avoid any kind of race 👍

@sloretz sloretz merged commit 1d45160 into master Aug 8, 2018
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Aug 8, 2018
@sloretz sloretz deleted the remove_node_actually_removes_node branch August 8, 2018 23:54
@sloretz sloretz mentioned this pull request Aug 15, 2018
Closed
12 tasks
mikaelarguedas pushed a commit that referenced this pull request Aug 20, 2018
@sloretz @mikaelarguedas
Fix executor.remove_node() (#217)
dcee92f
@mikaelarguedas mikaelarguedas mentioned this pull request Aug 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@sloretz sloretz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloretz @dirk-thomas @mikaelarguedas