refactor to allow for non-global init #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added
enhancement
sloretz
reviewed
Nov 22, 2018
wjwwood
force-pushed
the
refactor_init
branch
from
705a9d9
to
b377e79
Compare
jacobperron
approved these changes
Nov 26, 2018
Signed-off-by: William Woodall <william@osrfoundation.org>
wjwwood
force-pushed
the
refactor_init
branch
from
b377e79
to
0779fbd
Compare
|
LGTM |
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
sloretz
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable this pr, unlike the rclcpp one, does not provide access to the ingoing init options, partially because I think it's not as useful right now and partially because I'm completely out of time to work on this set of changes.
Connects to ros2/rmw#154