Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python thing that adds things to the wait set #250

Merged
merged 7 commits into from
Nov 26, 2018
Merged

Python thing that adds things to the wait set #250

merged 7 commits into from
Nov 26, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Nov 21, 2018

Python equivalent of ros2/rclcpp#589

@sloretz sloretz added the in progress Actively being worked on (Kanban column) label Nov 21, 2018
@sloretz sloretz added this to the crystal milestone Nov 21, 2018
@sloretz sloretz self-assigned this Nov 21, 2018
@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 21, 2018
jacobperron
jacobperron approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloretz
Copy link
Contributor Author

sloretz commented Nov 21, 2018

  • Linux Build Status
  • Linux-aarch64 Build Status

These failed due to jenkins issues, re-running

  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Nov 22, 2018

WIndows Build Status

OSX Build Status

@sloretz sloretz merged commit e05892e into master Nov 26, 2018
@sloretz sloretz deleted the waitable_rclpy branch November 26, 2018 17:27
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Nov 26, 2018
@sloretz sloretz mentioned this pull request Nov 27, 2018
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
crystal
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @jacobperron