Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer uses ROS time by default #419

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Timer uses ROS time by default #419

merged 1 commit into from
Sep 13, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Sep 6, 2019 •
edited
Loading

  • Renamed WallTimer to Timer and made it accept a clock
  • create_timer() uses the node's clock by default, which uses ROS time by default
  • Executor stores and reuses clock to pass to Timer

@sloretz
Timer uses ROS time by default
f02f0a0 
Renamed WallTimer to Timer and made it accept a clock
Executor stores and reuses clock to pass to Timer

Signed-off-by: Shane Loretz<sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Sep 6, 2019
@sloretz
Copy link
Contributor Author

sloretz commented Sep 6, 2019 •
edited
Loading

CI (testing packages above rclpy)

@tfoote tfoote mentioned this pull request Sep 6, 2019
Closed
8 tasks
@sloretz sloretz added the in review Waiting for review (Kanban column) label Sep 9, 2019
jacobperron
jacobperron approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sloretz sloretz merged commit a67cbfc into master Sep 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the create_timer_rostime branch September 13, 2019 22:08
@dirk-thomas dirk-thomas mentioned this pull request Sep 3, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas left review comments

@jacobperron jacobperron jacobperron approved these changes

Assignees

@sloretz sloretz

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sloretz @jacobperron @dirk-thomas